Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESENG-476 - Superuser to Administrator #2374

Merged
merged 9 commits into from
Feb 6, 2024

Conversation

ratheesh-aot
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-476

Description of changes:
Updated Superuser to Administrator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10bc112) 72.22% compared to head (ce621c0) 72.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2374   +/-   ##
=======================================
  Coverage   72.22%   72.22%           
=======================================
  Files         509      509           
  Lines       17129    17129           
  Branches     1288     1288           
=======================================
  Hits        12371    12371           
  Misses       4518     4518           
  Partials      240      240           
Flag Coverage Δ
metapi 86.91% <100.00%> (ø)
metweb 59.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/services/engagement_service.py 72.13% <ø> (ø)
met-api/src/met_api/services/membership_service.py 89.34% <ø> (ø)
met-api/src/met_api/services/staff_user_service.py 79.81% <ø> (ø)
met-api/src/met_api/utils/constants.py 95.00% <100.00%> (ø)
met-api/src/met_api/utils/enums.py 100.00% <100.00%> (ø)
met-api/src/met_api/utils/roles.py 100.00% <100.00%> (ø)
met-api/src/met_api/utils/tenant_validator.py 96.66% <ø> (ø)
...b/src/components/engagement/view/PreviewBanner.tsx 73.58% <ø> (ø)
met-web/src/components/survey/listing/Surveys.tsx 70.90% <ø> (ø)
...ponents/userManagement/listing/AssignRoleModal.tsx 46.07% <ø> (ø)
... and 2 more

Copy link
Collaborator

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good. Please just:

  • Correct a couple of grammar issues: "an Administrator"
  • Adjust the survey "Hidden" dialog message as indicated in my other comment.

met-api/src/met_api/services/membership_service.py Outdated Show resolved Hide resolved
met-api/src/met_api/services/staff_user_service.py Outdated Show resolved Hide resolved
met-web/src/components/survey/listing/Surveys.tsx Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ratheesh-aot ratheesh-aot merged commit c16efb8 into bcgov:main Feb 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants